Xml content type fix #760
Closed
Xml content type fix #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… work for content-types with charset (e.g. "text/xml;charset=UTF-8").
| @@ -628,7 +630,15 @@ public void setEditable(boolean enabled) { | |||
|
|
|||
| @Override | |||
| public int getSupportScoreForContentType(String contentType ) { | |||
| return contentType.toLowerCase().endsWith("xml")? 2 : 0; | |||
| if(contentType.endsWith("xml")){ | |||
There was a problem hiding this comment.
this is the standard behaviour for application/xml or else.
| if(contentType.endsWith("xml")){ | ||
| return 2; | ||
| } | ||
| Optional<String> any = Arrays.stream(contentType.split(";")) |
There was a problem hiding this comment.
If there is other stuff like charset or boundard or both, we get rid of that and do the check again.
…t already in the stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative soloution to
#725
We split the content type header with ";" and get rid off the charset and additional boundary Part.
We check for "endswith" xml instead of "contains" so we avoid to set
application/vnd.openxmlformats-officedocument. wordprocessingml.documentas a valid Type.Tested and works fine
Relates to #721