Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when command is one element in list (lxterminal affected). #10

Closed
wants to merge 1 commit into from

Conversation

k0ste
Copy link

@k0ste k0ste commented May 10, 2017

Hello.
One arg with 'command' not work with lxterminal, open lxtermianal without telnet session.

Not work:

['lxterminal', '-e', 'telnet 192.168.0.214 32769']

Work as expected:

['lxterminal', '-e', 'telnet', '192.168.0.214', '32769']
[k0ste@WorkStation ~]$ lxterminal --version
lxterminal 0.3.0
[k0ste@WorkStation ~]$ 

This patch make elements separated, should not be a regression with another terminal emulators. But you should check it.
Thanks.

@SmartFinn
Copy link
Owner

Hello.

This patch conflicts with #8. Also, it doesn't resolve the issue on Debian-based systems where used x-terminal-emulator as a default terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants