Aqara Curtain Driver E1 #1457
Open
Aqara Curtain Driver E1 #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 60 files 378 suites 0s ⏱️ Results for commit 1955e60. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1955e60 |
greens
reviewed
Jul 11, 2024
Comment on lines
67
to
75
| local data = data_types.validate_or_build_type(value, data_type) | ||
| local message = cluster_base.write_attribute(device, data_types.ClusterId(cluster), attribute, data) | ||
| if mfg_code ~= nil then | ||
| message.body.zcl_header.frame_ctrl:set_mfg_specific() | ||
| message.body.zcl_header.mfg_code = data_types.validate_or_build_type(mfg_code, data_types.Uint16, "mfg_code") | ||
| else | ||
| message.body.zcl_header.frame_ctrl = FrameCtrl(0x10) | ||
| end | ||
| return message |
There was a problem hiding this comment.
nit: we use 2 spaces instead of tabs
greens
reviewed
Jul 11, 2024
greens
reviewed
Jul 11, 2024
Comment on lines
179
to
193
| test.register_coroutine_test( | ||
| "Window shade open cmd handler", | ||
| function() | ||
| test.socket.capability:__queue_receive( | ||
| { | ||
| mock_device.id, | ||
| { capability = "windowShade", component = "main", command = "open", args = {} } | ||
| } | ||
| ) | ||
| -- test.socket.zigbee:__expect_send({ | ||
| -- mock_device.id, | ||
| -- WindowCovering.server.commands.UpOrOpen(mock_device, 'open') | ||
| -- }) | ||
| end | ||
| ) |
There was a problem hiding this comment.
you need to write this test so that the initialization happens so that the test can verify the command is actually sent in that case
or, ideally, you have a test for both possibilities: initialized and uninitialized
greens
reviewed
Jul 12, 2024
| @@ -217,6 +218,7 @@ local aqara_window_treatment_handler = { | |||
| }, | |||
| sub_drivers = { | |||
| require("aqara.roller-shade"), | |||
| require("aqara.curtain-driver-e1"), | |||
wkhenon
approved these changes
Jul 15, 2024
greens
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.