Add device configuration for matter-fan #1460
Open
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 59 files 375 suites 0s ⏱️ Results for commit ba3a5d3. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ba3a5d3 |
|
I believe this will solve the issue in the future when we can use this: https://github.ecodesamsung.com/iot/SmartThingsCapabilities/pull/351 @HunsupJung could we wait for the new capability to use here, or do we need to make this change now? |
|
We can use Fan Mode capability that you made. Thank you 👍 |
|
@ctowns When should we change the airConditionFanMode to the newly created Fan Mode capability? |
|
@ctowns |
ctowns
approved these changes
Jul 15, 2024
hcarter-775
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matter-fan driver uses airCondtionerFanMode and its label is "Air Condtioner Fan Mode".
This is for changing a label to "Fan Mode" from "Air Conditioner Fan Mode"