Fix text-to-speech feature #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor case statement so custom message works. Remove comment from input selection.
|
the default value was set to Custom before @Yaima made the change in december. do you want to change that too? |
|
The "bell" sound was wrapped into the default case so it would evaluate the if/else and then the last line of the default case was to set the set the sound to "bell". Splitting custom message into a separate case and making the "bell" sound default allowed the custom message to be successfully set. |
|
👍 |
b-pass
pushed a commit
to b-pass/SmartThingsPublic
that referenced
this pull request
Jan 15, 2017
Fix text-to-speech feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor case statement so custom message works. Remove comments from input selection.
cc @bflorian @workingmonk @Yaima