This repository has been archived by the owner on Feb 3, 2022. It is now read-only.
add DynamoDB context store implementation #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erodewald
suggested changes
Jun 19, 2019
|
|
||
| @Override | ||
| public void add(DefaultInstalledAppContext context) { | ||
| Table table = dynamoDB.getTable("InstalledAppContext"); |
There was a problem hiding this comment.
It wasn't in the requirements, but I think that this plugin should name tables and keys in the exact same manner as the NodeSDK to make the data compatible regardless of the SDK language.
There was a problem hiding this comment.
I changed this. :-(
I didn't include the client id and secret and wrote the following two issues to remove them from the NodeJS context store implementations:
SmartThingsCommunity/dynamodb-context-store-nodejs#1
SmartThingsCommunity/firestore-context-store-nodejs#10
I'm also still including token expirations and scope which are not included in the NodeSDK version.
erodewald
approved these changes
Jun 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an implementation of the new context store using DynamoDB.