feat: add support for Q&A Schema App input #539
Conversation
🦋 Changeset detectedLatest commit: 72ec19d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rossiam
force-pushed
the
schema-app-qa-input
branch
from
a0bde6e
to
232d0a4
Compare
| oAuthClientId: stringDef('Partner OAuth Client Id'), | ||
| oAuthClientSecret: stringDef('Partner OAuth Client Secret'), | ||
| oAuthTokenUrl: stringDef('Partner OAuth Refresh Token URL', { validate: httpsURLValidate }), | ||
| oAuthScope: stringDef('Partner OAuth Scope'), |
There was a problem hiding this comment.
The scope is actually optional. I imagine most real integrations will have it, but Viper doesn't require it and examples sometimes omit it.
| icon3x: optionalStringDef('3x Icon URL', { validate: httpsURLValidate }), | ||
| oAuthClientId: stringDef('Partner OAuth Client Id'), | ||
| oAuthClientSecret: stringDef('Partner OAuth Client Secret'), | ||
| oAuthTokenUrl: stringDef('Partner OAuth Refresh Token URL', { validate: httpsURLValidate }), |
There was a problem hiding this comment.
Minor UI point, but I think it's easier if oauthTokenUrl immediately follows oauthAuthorizationUrl since they are both likely to be copied and pasted from the same root URL.
|
|
||
| const helpText = awsHelpText | ||
| const initiallyActive = initialValue?.hostingType === 'lambda' | ||
| console.error(`initiallyActive is ${initiallyActive} for ${name} because initialValue?.hostingType = ${initialValue?.hostingType}`) |
There was a problem hiding this comment.
Oops, meant to take that out. Fixed.
| } | ||
|
|
||
| const initiallyActive = initialValue?.hostingType === 'webhook' | ||
| console.error(`initiallyActive is ${initiallyActive} for Webhook URL because initialValue?.hostingType = ${initialValue?.hostingType}`) |
There was a problem hiding this comment.
Oops, didn't mean to leave that in. Fixed.
rossiam
force-pushed
the
schema-app-qa-input
branch
from
232d0a4
to
d60ce66
Compare
Not nits at all. Glad to fix those things! |
rossiam
force-pushed
the
schema-app-qa-input
branch
from
d60ce66
to
72ec19d
Compare
Add support for Q&A input for Schema Apps.
Checklist
npm run lintproduces no warnings/errors)