fix: minor history fixes #566
Conversation
🦋 Changeset detectedLatest commit: de1a160 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| break | ||
| } | ||
|
|
||
| const table = command.tableGenerator.newOutputTable({ isList: true, head }) |
There was a problem hiding this comment.
I didn't know you could re-define a const in a more restricted context like this. Neat. But could certainly get confusing in a less straightforward situation than this one.
There was a problem hiding this comment.
Yeah, this is something you should generally avoid because it can be confusing. I decided to go with it in this case since both variables are created and used in just a few lines of code (and I really wanted that same name for both of them since they do the same thing) but I wouldn't fight if you wanted me to change it.
| @@ -132,6 +131,11 @@ export const getHistory = async (client: SmartThingsClient, limit: number, perRe | |||
| const items: DeviceActivity[] = [...history.items] | |||
| while (items.length < limit && history.hasNext()) { | |||
| await history.next() | |||
| // The API allows the user to continue to records before the specified after with paging so | |||
There was a problem hiding this comment.
This wording is a little hard to follow. I think it's "continue to records before the specified after" that confuses me--maybe something like "continue to retrieve records before the specified 'after' date"?
There was a problem hiding this comment.
Confusing? That's an understatement. Mangled is more like it. 😄 I must have messed this in editing. I've updated it to:
// The API allows the user to continue to view history from before the specified "after"
// with paging so we stop processing if we get items that come before the specified "after".
rossiam
force-pushed
the
history-fixes
branch
from
712160c
to
de1a160
Compare
beforeandafterflags as seconds since the epoch as describe in the helpconfirminquirer input type for y/n question instead of text inputafterafterbut allows the user to continue on with the "next" page linkafterflagChecklist
npm run lintproduces no warnings/errors)