Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for api-command.ts #578

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

rossiam
Copy link
Collaborator

@rossiam rossiam commented Jan 3, 2024

  • moved old unit tests file from packages dir into new structure (done as a separate commit)
  • rewrote those unit tests for yargs and ESM
  • added st-client-wrapper.ts with a couple of very thin wrappers around a couple of classes from the core SDK to make them easier to mock
  • default the generic type for SmartThingsCommand to SmartThingsCommandFlags (the minimum necessary) so we don't have to specify it for commands and unit tests that don't add flags

Copy link

changeset-bot bot commented Jan 3, 2024

⚠️ No Changeset found

Latest commit: f67e4a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rossiam rossiam merged commit d81ffbc into SmartThingsCommunity:yargs Jan 4, 2024
4 checks passed
@rossiam rossiam deleted the api-command-tests branch January 4, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants