Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert locations:create command to yargs #598

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

rossiam
Copy link
Collaborator

@rossiam rossiam commented Mar 1, 2024

  • converted locations:create and its unit tests to yargs
  • removed some extra blank lines in help output

Copy link

changeset-bot bot commented Mar 1, 2024

⚠️ No Changeset found

Latest commit: a0f3b23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

const { default: cmd } = await import('../../../commands/locations/create.js')


type BuilderFunctionMock<T extends FunctionLike> = jest.Mock<T> & T
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I've been duplicating this but I plan to put it in a utility module when I do some refactoring after getting a couple more commands with tests converted.

@rossiam rossiam merged commit 24b6e9d into SmartThingsCommunity:yargs Mar 1, 2024
4 checks passed
@rossiam rossiam deleted the locations-create-yargs branch March 1, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants