Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UEFA new layout shtml #283

Merged
merged 1 commit into from
Dec 2, 2019
Merged

UEFA new layout shtml #283

merged 1 commit into from
Dec 2, 2019

Conversation

rosieprom
Copy link
Contributor

  • Done simple html/css layout
  • Tested on another iPhone, need to test on Android

@bitcoinwarrior1
Copy link
Contributor

IMG_1385
@developerpeachy possible to fix this?

@rosieprom
Copy link
Contributor Author

hey james, what phone is this running on and how can i get two cards showing on my build to test and fix

@rosieprom
Copy link
Contributor Author

Suggestion: can we remove unnecessary margins in webview? is this possible?

@hboon
Copy link
Member

hboon commented Dec 2, 2019

Suggestion: can we remove unnecessary margins in webview? is this possible?

@developerpeachy @James-Sangalli Fixed with AlphaWallet/alpha-wallet-ios#1596

Copy link
Contributor

@bitcoinwarrior1 bitcoinwarrior1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@developerpeachy Merging, took the liberty to rebase your commits :)

@bitcoinwarrior1 bitcoinwarrior1 merged commit 9b55c27 into master Dec 2, 2019
@bitcoinwarrior1 bitcoinwarrior1 deleted the UEFA-new-layout-shtml branch December 2, 2019 05:36
@bitcoinwarrior1
Copy link
Contributor

bitcoinwarrior1 commented Dec 2, 2019

Added #284 for the redeem section, please pull from master and make a new PR and branch for this change @developerpeachy

@bitcoinwarrior1
Copy link
Contributor

Closes #286 @developerpeachy remember to reference relevant issues

SmartLayer pushed a commit that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants