don't approve me, work in progress for cryptokitties xml

[bitcoinwarrior1]

for #34
@James-Sangalli sorted stuff into sub-directories in this pR>

[hboon]

@James-Sangalli

1. Is it supposed to be complete? For example, there's "coralsunrise" for eye-colour that isn't in the XML.

2. For https://www.cryptokitties.co/kitty/800058, I tried mapping with getKitty(800058) (and getting genes) to get 689278284593481476509607714409998114129040247814513095176469160709554223 which converted to binary is 011000111101111011000000101001011010010001010000110001100011000100001000010011110110000110001010111101111010010111101111000110010101101000100010101000010100111101100000000111000001000000111101111010110001000001001000101000111000000000101111

And with the XML, I'm getting:

pattern-type 00100 = 4 = ? (should be amur)
eye-color 00011 = 3 = mintgreen (should be coralsunrise)

Am I doing it wrong?

3. We need to call getKitty(kittyId) (genes is the last element in the result) and this isn't part of ERC721. Maybe we need a way to define the getKitty() call and how to interpret the results in the asset definition too? Or hardcode that call for CryptoKitties until we can generalise this?

Update: was looking up wrong kitty ID (80059 instead of 80058). Have updated above

[hboon]

Also, do we support specifying the bitmask as both binary and hex strings? i.e. the parser has to read the length to determine if it is binary/hex? Or should we just use hex? (kitty's is in binary and ticket's is in hex now)

[bitcoinwarrior1]

@hboon hmmm, seems the image I am basing off from the article does not match the reality?

[bitcoinwarrior1]

@colourful-land bump

[hboon]

@James-Sangalli I might be parsing the numbers incorrectly. Would be good if you can help verify. But it does seem to be missing some of the cattribute values.

[hboon]

@James-Sangalli it seems the XML's bitmask assumes a reversed order of the gene groups:

For example, body which is this in the XML:

000000000000000111110000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000

should be:

000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001111 body

Similarly:

000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000011111000000000000000000000000000000000000000000000000000000000000 eye-type/shape
000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001111100000000000000000000 pattern-type

But unless there's another source, we'll have to figure out the missing cattribute values ourselves.

[SmartLayer]

I can't approve this unless the repo server is updated to handle directory hierarchy since you created a subdirectory in this branch.

[SmartLayer]

@James-Sangalli 1) suggest to split this into 2 pr in the future since "sort into folders" is a big change. 2) Approve this first so I can approve yours: AlphaWallet/alpha-wallet-android#299

[SmartLayer]

@James-Sangalli says this one should wait - don't approve it because he is still working on it

[bitcoinwarrior1]

Replaced by services like OpenSea