Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes added to VideoBg tag #2

Closed
Agent9G opened this issue Sep 3, 2019 · 7 comments · Fixed by #3
Closed

Attributes added to VideoBg tag #2

Agent9G opened this issue Sep 3, 2019 · 7 comments · Fixed by #3
Labels
bug Something isn't working released

Comments

@Agent9G
Copy link

Agent9G commented Sep 3, 2019

How am i to add attributes to this tag.

i currently have such:
<VideoBg loop={false} muted={false} poster={...}>

I am getting the warning fro both
'Failed prop type: Invalid prop loopof type booleansupplied to j, expected string.

@Agent9G
Copy link
Author

Agent9G commented Sep 3, 2019

The other thing, is it possible to make the poster show after the video has played?

@samAbeywickrama samAbeywickrama added the bug Something isn't working label Sep 4, 2019
@samAbeywickrama
Copy link
Contributor

The other thing, is it possible to make the poster show after the video has played?

This is not supported, Planing to implement this soon :)

@samAbeywickrama
Copy link
Contributor

How am i to add attributes to this tag.

i currently have such:
<VideoBg loop={false} muted={false} poster={...}>

I am getting the warning fro both
'Failed prop type: Invalid prop loopof type booleansupplied to j, expected string.

I have done a silly mistake in proptype validation in https://github.com/samAbeywickrama/reactjs-videobg/blob/master/src/VideoBg.js 😅

  loop: PropTypes.string,

It has to be

  loop: PropTypes.bool,

I will add a fix to this and do a release asap :)

rasulacaldera pushed a commit that referenced this issue Sep 4, 2019
Changed string proptype to boolean

Closes: #2
@samAbeywickrama
Copy link
Contributor

🎉 This issue has been resolved in version 1.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rasulacaldera
Copy link
Collaborator

The other thing, is it possible to make the poster show after the video has played?

This is not supported, Planing to implement this soon :)

Working on this here #4

@Agent9G
Copy link
Author

Agent9G commented Sep 4, 2019

The other thing, is it possible to make the poster show after the video has played?

This is not supported, Planing to implement this soon :)

Solid!

@Agent9G
Copy link
Author

Agent9G commented Sep 4, 2019

How am i to add attributes to this tag.
i currently have such:
<VideoBg loop={false} muted={false} poster={...}>
I am getting the warning fro both
'Failed prop type: Invalid prop loopof type booleansupplied to j, expected string.

I have done a silly mistake in proptype validation in https://github.com/samAbeywickrama/reactjs-videobg/blob/master/src/VideoBg.js

  loop: PropTypes.string,

It has to be

  loop: PropTypes.bool,

I will add a fix to this and do a release asap :)

You da champ!

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants