Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended metadata to gemspec #159

Merged
merged 2 commits into from
May 16, 2020

Conversation

kinow
Copy link
Member

@kinow kinow commented May 16, 2020

Ref: https://guides.rubygems.org/specification-reference/#metadata

@kinow kinow self-assigned this May 16, 2020
@kinow kinow added this to the 1.2 milestone May 16, 2020
@kinow
Copy link
Member Author

kinow commented May 16, 2020

Tested locally with bundle install. First it failed as I used { :key = "value" }. Then when I used strings as in the docs it worked with no issues 👍

@kinow kinow marked this pull request as ready for review May 16, 2020 23:45
s.date = '2016-10-23'

s.version = '1.1.0'
s.date = '2017-12-25'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetched data from rubygems.org

@@ -13,6 +14,16 @@ Gem::Specification.new do |s|
s.homepage = 'http://smashing.github.io/smashing'
s.license = "MIT"

s.metadata = {
"bug_tracker_uri" => "https://github.com/Smashing/smashing/issues",
# "changelog_uri" => "https://github.com/Smashing/smashing/CHANGELOG.md",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kinow kinow merged commit 169ec75 into Smashing:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant