Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch to not filter events #184

Merged
merged 4 commits into from
Mar 6, 2021

Conversation

toy
Copy link
Contributor

@toy toy commented Mar 6, 2021

No description provided.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested checking out this branch, building the gem, then changing Dashing.filterEvents = {true|false}. Refreshing the dashboard, I could see in the network tab it was alternating between /events and /events?ids=synergy,... as I changed filterEvents value.

@toy I'm cutting a new release, and have prepared a quick Wiki with more about this new feature. Could you take a look to see if that looks OK? Feel free to edit if necessary 👍

https://github.com/Smashing/smashing/wiki/How-to%3A-Filter-events-received-by-dashboards

And big thank you for your PR's!
Bruno

@kinow kinow merged commit a489145 into Smashing:master Mar 6, 2021
@kinow kinow added this to the 1.3.4 milestone Mar 6, 2021
@toy
Copy link
Contributor Author

toy commented Mar 6, 2021

https://github.com/Smashing/smashing/wiki/How-to%3A-Filter-events-received-by-dashboards

Just expanded the sentence about were the switch can be set to also mention individual dashboards.

@toy toy deleted the switch-to-not-filter-events branch March 6, 2021 20:20
@kinow
Copy link
Member

kinow commented Mar 6, 2021

Thank you @toy!

Pushing to RubyGems right now.

@kinow
Copy link
Member

kinow commented Mar 6, 2021

1.3.4 released https://rubygems.org/gems/smashing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants