Use dynamic settings instead of config resolver #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your help. sorry for bad usage of dependency injection |
noodle69
added a commit
that referenced
this pull request
Oct 23, 2015
Use dynamic settings instead of config resolver
Come on. You wouldn't believe what I've put the container through on some occasions ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
ContainerAware+ConfigResolverwith injection of dynamic settings fromservices.yml. We find it easier to maintain, maybe you'll think the same.The settings are passed with setters and not the constructor so that the values can be updated on siteaccess change without resetting the service.