Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spellchecker / Fuzzy queries refactoring. #1266

Closed
romainruaud opened this issue Jan 16, 2019 · 2 comments
Closed

Spellchecker / Fuzzy queries refactoring. #1266

romainruaud opened this issue Jan 16, 2019 · 2 comments
Labels
enhancement
Projects
Release 2.9 Priority

Comments

@romainruaud
Copy link
Collaborator

romainruaud commented Jan 16, 2019 •
edited

There are functional holes in the spellchecking / fuzzy query building.

  • termVectors query is run against 'spelling' field, so only against 'is_used_in_spellcheck' fields.

  • if no results, a fuzzy query is built on 'spelling', and on all 'is_used_in_spellcheck' fields (having a weight > 1).

=> can cause 0 results for a query that should have some (value can exist on a field which is not 'used_in_spellcheck').
@romainruaud romainruaud added this to To do in Release 2.8 via automation Jan 16, 2019
@romainruaud romainruaud removed this from To do in Release 2.8 Apr 12, 2019
@romainruaud romainruaud added this to To do in Release 2.9 via automation Apr 12, 2019
@romainruaud romainruaud mentioned this issue Jul 8, 2019
Closed
@romainruaud romainruaud added this to To do in Priority Jul 30, 2019
@southerncomputer
Copy link
Contributor

any progress on this?

@romainruaud
Copy link
Collaborator Author

At some point, we also used "search" meta-field for term vectors : 13fb6f9

romainruaud added a commit to romainruaud/elasticsuite that referenced this issue Jan 3, 2023
@romainruaud
Fix Smile-SA#1266 by making the term vectors on all shards and testin…
de285c3 
…g also 'search field'.
romainruaud added a commit to romainruaud/elasticsuite that referenced this issue Jan 4, 2023
@romainruaud
Fix Smile-SA#1266 by making the term vectors on all shards and testin…
81b21dc 
…g also 'search field'.
romainruaud added a commit to romainruaud/elasticsuite that referenced this issue Jan 4, 2023
@romainruaud
Fix Smile-SA#1266 by making the term vectors on all shards and testin…
9db00fd 
…g also 'search field'.
romainruaud added a commit that referenced this issue Jan 11, 2023
@romainruaud
Merge pull request #2812 from romainruaud/fix_term-vectors-refactoring
8575645 
Fix #1266 by making the term vectors on all shards and search field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
No open projects
Priority
  
To do
Release 2.9
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@southerncomputer @romainruaud