Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various errors detected by static testing #41

Closed
romainruaud opened this issue Jun 3, 2016 · 2 comments
Closed

Fix various errors detected by static testing #41

romainruaud opened this issue Jun 3, 2016 · 2 comments
Assignees
@afoucret
Labels
enhancement

Comments

@romainruaud
Copy link
Collaborator

romainruaud commented Jun 3, 2016 •
edited by afoucret

bin/magento dev:tests:run static detects some errors :

  • duplicate keys in DI
  • layouts mistakes (especially in tracker module)
  • cosmetics in composer.json files (essentially "no space after colon")
@romainruaud romainruaud added this to the v 2.1 milestone Jun 3, 2016
@romainruaud romainruaud self-assigned this Jun 3, 2016
@afoucret afoucret assigned afoucret and unassigned romainruaud Jun 6, 2016
@afoucret
Copy link
Contributor

afoucret commented Jun 6, 2016

The few remaining cases are not critcal and can be fixed in a later version

@afoucret afoucret modified the milestones: 2.2, v 2.1 Jun 6, 2016
@phronesis phronesis mentioned this issue Aug 15, 2016
Closed
@romainruaud romainruaud modified the milestones: 2.3, 2.2 Sep 26, 2016
@southerncomputer southerncomputer mentioned this issue Oct 17, 2016
Closed
@globallydigital globallydigital mentioned this issue Nov 26, 2016
Closed
@afoucret afoucret modified the milestones: 2.3, 2.4 Jan 4, 2017
@woutersamaey woutersamaey mentioned this issue Jun 9, 2017
Closed
@afoucret afoucret removed this from the 2.4 milestone Feb 1, 2018
@afoucret
Copy link
Contributor

Seems it can be closed

@Streetec Streetec mentioned this issue Sep 18, 2018
Closed
@setrada setrada mentioned this issue Jan 11, 2021
Closed
botisSmile pushed a commit to botisSmile/elasticsuite that referenced this issue Sep 8, 2021
@romainruaud
Merge pull request Smile-SA#41 from Elastic-Suite/feat-ESP-87-Create-…
53b1cdf 
…Optimizer

[Campaign] Create optimizer in the admin campaign form #ESP-87
@ghost ghost mentioned this issue Jul 31, 2022
Closed
@menardavid menardavid mentioned this issue Nov 10, 2022
Closed
@thunder809 thunder809 mentioned this issue Dec 22, 2022
Closed
@Minirock Minirock mentioned this issue Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afoucret afoucret

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afoucret @romainruaud