Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No check against $options in attribute filter layer. ~@2.2.x #68

Closed
rootindex opened this issue Jun 27, 2016 · 3 comments · Fixed by #82
Closed

No check against $options in attribute filter layer. ~@2.2.x #68

rootindex opened this issue Jun 27, 2016 · 3 comments · Fixed by #82

Comments

@rootindex
Copy link 

1 exception(s):
Exception #0 (Exception): Warning: Invalid argument supplied for foreach() in /www/vendor/smile/elasticsuite/src/module-elasticsuite-catalog/Model/Layer/Filter/Attribute.php on line 216

Exception #0 (Exception): Warning: Invalid argument supplied for foreach() in /www/vendor/smile/elasticsuite/src/module-elasticsuite-catalog/Model/Layer/Filter/Attribute.php on line 216

A fix was if (count($options)) { ... }, sadly no time to push a fix guys (deadlines my side).
@afoucret
Copy link
Contributor

Hi @rootindex,

I would be very interested in having your code pushed if you have more time now.

@rootindex rootindex mentioned this issue Jul 12, 2016
Merged
@southerncomputer
Copy link
Contributor

rootindex@2c137be

He posted it in his fork!

@afoucret
Copy link
Contributor

PR has been merged

@phronesis phronesis mentioned this issue Aug 15, 2016
Closed
@southerncomputer southerncomputer mentioned this issue Oct 18, 2016
Closed
@woutersamaey woutersamaey mentioned this issue Jun 9, 2017
Closed
romainruaud pushed a commit to romainruaud/elasticsuite that referenced this issue Nov 24, 2021
@rbayet
Merge pull request Smile-SA#68 from Elastic-Suite/feat-ESP-19-ab-test…
783c986 
…ing-rest-graphql

[Campaign][Headless] Retrieve/Apply current scenario #ESP-94 #ESP-103
@ghost ghost mentioned this issue Jul 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Options could be empty, validation added rootindex/elasticsuite
3 participants
@rootindex @afoucret @southerncomputer