Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static testing #40

Merged
merged 2 commits into from
Jun 3, 2016
Merged

Fix static testing #40

merged 2 commits into from
Jun 3, 2016

Conversation

romainruaud
Copy link
Collaborator

@romainruaud romainruaud commented Jun 3, 2016 •
edited

Ensure ability to process static testing :

  • move module-elasticsuite-catalog/Model/Layer/Filter/Item/AttributeFactory.php to a virtual type
  • same thing for module-elasticsuite-catalog/Model/Layer/Filter/Item/CategoryFactory.php
  • fixing the Usage of field Iterator by using an alias, which prevent it to fail during static testing.

This will fix #38

@romainruaud romainruaud added the bug label Jun 3, 2016
@romainruaud romainruaud added this to the v 2.1 milestone Jun 3, 2016
@afoucret afoucret merged commit 8ec15d2 into Smile-SA:master Jun 3, 2016
@phronesis phronesis mentioned this pull request Aug 15, 2016
Closed
@southerncomputer southerncomputer mentioned this pull request Oct 17, 2016
Closed
@romainruaud romainruaud deleted the fix_static-testing branch October 27, 2016 13:26
@globallydigital globallydigital mentioned this pull request Nov 26, 2016
Closed
@woutersamaey woutersamaey mentioned this pull request Jun 9, 2017
Closed
@Streetec Streetec mentioned this pull request Sep 18, 2018
Closed
@isabelcelima isabelcelima mentioned this pull request Nov 15, 2019
Closed
@setrada setrada mentioned this pull request Jan 11, 2021
Closed
botisSmile pushed a commit to botisSmile/elasticsuite that referenced this pull request Sep 8, 2021
@rbayet
Merge pull request Smile-SA#40 from Elastic-Suite/fix-package-tags-case
a00c1c8 
Fixing @Package tags
@ghost ghost mentioned this pull request Jul 31, 2022
Closed
@menardavid menardavid mentioned this pull request Nov 10, 2022
Closed
@thunder809 thunder809 mentioned this pull request Dec 22, 2022
Closed
@Minirock Minirock mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@afoucret afoucret

Labels
bug
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Class 'Magento\Catalog\Model\Layer\Filter\ItemFactory' not found
2 participants
@romainruaud @afoucret