DX: Mention table and column-name in unqiue error message

[staabm]

PR Checklist

Please check if your pull request fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/Smile-SA/gdpr-dump/blob/main/CONTRIBUTING.md.
• Tests for the changes have been added (for bug fixes / features).
• Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

$ php bin/gdpr-dump config.yaml 
...
Maximum retries of 0 reached without finding a unique value.

Issue Number: #109

What is the new behavior?

$ php bin/gdpr-dump config.yaml 
...
erp_user.first_name: Maximum retries of 0 reached without finding a unique value.

note the table.column-name prefix before the error message

Does this PR introduce a breaking change?

[ ] Yes
[ ] No
[x] Maybe

Other information

[staabm]

just saw and fixed the phpcs errors, sorry for not realizing it in the first place

[guvra]

Hi @staabm,

I see you already updated the PR 👍
Could you also change it to catch all exceptions instead of just overflow exception (so that it works for all converters)?

[guvra]

And also add imports for exceptions with use ... at the beginning of the file

[staabm]

sure thing, fixed. thanks for the fast feedback.

[guvra]

Thanks, the last change required is to sort the use you added, otherwise php codesniffer is not happy 😄

[staabm]

here we go

[staabm]

thank you @guvra. may I ask you about your plans, for a new release?

[guvra]

thank you @guvra. may I ask you about your plans, for a new release?

Thanks you too for your contribution!
I updated the changelog, i'm currently running some tests on magento/shopware databases.
If they succeed, I will probably be able to publish a release today but no promises.