Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear "limit of gift products" on frontend. #3

Closed
romainruaud opened this issue Mar 26, 2019 · 2 comments
Closed

Unclear "limit of gift products" on frontend. #3

romainruaud opened this issue Mar 26, 2019 · 2 comments
Assignees
@maximequeneau
Labels
bug Something isn't working

Comments

@romainruaud
Copy link
Contributor

I create a rule with "Maximum number product offered" (missing translation here :) ) = 2.

On the cart page, I choose one gift, then another. They appear in my cart as attended.

If I select another gift, I got the message "You added gift product to your shopping cart." but the product is not added.

Maybe in this case we should have a message indicating clearly that maximum number of gifted products has been reached on the current cart.
@romainruaud romainruaud added the bug Something isn't working label Mar 26, 2019
@maximequeneau
Copy link
Contributor

Fix by frontend developpement. Now, it's not possible to add more product than defined in the rule.

romainruaud added a commit that referenced this issue Jun 6, 2019
@romainruaud
Merge pull request #10 from maximequeneau/master
dce6dd5 
Fix issue #3 and #5
@romainruaud
Copy link
Contributor Author

Closed by associated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximequeneau maximequeneau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maximequeneau @romainruaud