Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place order issue #30

Closed
jigsawyer opened this issue Oct 2, 2020 · 3 comments
Closed

Place order issue #30

jigsawyer opened this issue Oct 2, 2020 · 3 comments

Comments

@jigsawyer
Copy link

jigsawyer commented Oct 2, 2020 •
edited

Hello.
We faced loop issue, during place order , for which cart rule is applied.
During payment method save
vendor/magento/module-quote/Model/PaymentMethodManagement.php:52 is triggered CollectTotals process. And during this process triggered Observer vendor/smile/module-gift-sales-rule/Observer/SetNumberOfferedProduct.php ,in which quote is retrieved from session, and as it has TotalsCollected = false - process begin from scratch.
On the older version 1.1.0 - everything is OK.

Module version 1.1.1
Magento version Cloud 2.3.5 -p2

Best regards
@jigsawyer
Copy link
Author

More information:

@PierreLeMaguer
Copy link
Contributor

Hi,

I see, we will try to fix that as soon as possible.
We need to avoid to use the session quote here vendor/smile/module-gift-sales-rule/Observer/SetNumberOfferedProduct.php .
Thanks for the report of the issue !

PierreLeMaguer added a commit that referenced this issue Oct 5, 2020
@PierreLeMaguer
[GetQuote Loop] #30 - Avoid to use getQuote checkout session method t…
d58f306 
…o avoid an infinite loop
@PierreLeMaguer PierreLeMaguer mentioned this issue Oct 5, 2020
Merged
maximequeneau pushed a commit that referenced this issue Oct 5, 2020
@PierreLeMaguer @maximequeneau
[GetQuote Loop] #30 - Avoid to use getQuote checkout session method t…
11022c2 
…o avoid an infinite loop
@maximequeneau
Copy link
Contributor

Fix by Pierre Le Maguer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jigsawyer @maximequeneau @PierreLeMaguer