Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply only with reloading page #44

Closed
iloa08 opened this issue Nov 9, 2020 · 6 comments
Closed

Apply only with reloading page #44

iloa08 opened this issue Nov 9, 2020 · 6 comments

Comments

@iloa08
Copy link

iloa08 commented Nov 9, 2020

Thanks for this module.
However I have a problem : the gift proposal appears only after reloading the page.
Am I the only one with this feat ?

@PierreLeMaguer
Copy link
Contributor

Hello,

a similar issue was identified here #43 . We are working on it.
Can you tell us the magento version and the module version you are using ?
And if the configuraiton sales/msrp/enabled is enabled ?

Thanks,
Pierre

@iloa08
Copy link
Author

iloa08 commented Nov 10, 2020

Magento 2.3.3
magento2-module-gift-sales-rule-1.1.4
no MAP - no MSRP
Thanks

PierreLeMaguer added a commit that referenced this issue Nov 10, 2020
…and base the price range logic on the subtotal including tax instead of the grand total
maximequeneau pushed a commit that referenced this issue Nov 16, 2020
…and base the price range logic on the subtotal including tax instead of the grand total
maximequeneau pushed a commit that referenced this issue Nov 16, 2020
…and base the price range logic on the subtotal including tax instead of the grand total
@iloa08
Copy link
Author

iloa08 commented Nov 24, 2020

Problem is always present on my test after updating.

@PierreLeMaguer
Copy link
Contributor

Hello,

can you describe with more details how do you reproduce the issue ?
Magento Version ?
Gift Sales Rule Module Version ?
The configuration of your salesrule ?
The different steps to reproduce ?
Third module ?

Thanks,
Pierre

@iloa08
Copy link
Author

iloa08 commented Dec 3, 2020

Magento 2.3.3
your last version on github
no MAP - no MSRP

test with rule OK
If ALL of these conditions are TRUE
Subtotal equals or greater than 200

test with rule NOT OK
If ALL of these conditions are TRUE
Subtotal (Excl. Tax) equals or greater than 100
If total quantity equals or greater than 1 for a subselection of items in cart matching ALL of these conditions:
Marque is Xxxxx

No Third module on checkout page
I can give you the url for test

Thanks

EDIT : after other tests all seems to be ok > sorry !

@PierreLeMaguer
Copy link
Contributor

@iloa08 , Ok, thanks for your submission. We close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants