Fixes and improvements #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should be no user visible change from this, except that tile size now affects performance. The goal here is to simplify bake denoising in D3099, letting it reuse more denoising tiles and pass code. A lot of code is now shared with regular rendering, with the two main differences being that we read some render result passes from the bake API when starting to render a tile, and call the bake kernel instead of the path trace kernel. With this kind of design where Cycles asks for tiles from the bake API, it should eventually be easier to reduce memory usage, show tiles as they are baked, or bake multiple passes at once, though there's still quite some work needed for that. Reviewers: #cycles Subscribers: monio, wmatyjewicz, lukasstockner97, michaelknubben Differential Revision: https://developer.blender.org/D3108
Enabling "Use High Quality Display" in the graph editor enables AA for the curves, this enables it for bezier handles too. Differential Revision: https://developer.blender.org/D7740
This commit lays the foundation for support for OpenVDB caching with multiple grids per cache file.
cb252ca8d316 was also needed to fix the velocity loading from the cache.
A parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax. Removing the cast seems fine for both MSVC and GCC
This reverts commit 54ea356 it introduced crashes when trying to go to edit mode when the active object was hidden. Fix T76837
Re-apply changes from 54ea356, with a poll function that uses the same active object as the operator, matching other mode switching functions.
The RNA name property of pose bones did not have any update logic defined. Same issue also applied to the channel name in animation editors. Duplicated the update logic from (edit-)bones now, other pose bone functions do this too...
For some reason was only visible with gcc-10 in release builds. Kind of makes sense since there is no CMake code which removes strict compiler flag, so deal with strict flags in the code itself.
It is not enough to copy max of destination buffer size bytes, the source might be smaller than the destination size.
Simple solution: remove the code which was causing bad threading conflicts. This code was a part of workaround for a specific state of linked scene. It seems to be not needed anymore, since the pose is ensured to be up to date by the following call stack: - Dependency graph update, - Copy-=on-write operation called on object. - object_copy_data(). - BKE_pose_rebuild(). The workaround was a no-functional change for the dependency graph anyway, because it was modifying original objects, not the ones which are evaluated.
It is not impossible that the number of knots is stored wrong in the file (for example, it will be 1 knot only). This change fixes bad memory allocation and bad memory access in such cases. It also fixes strict compiler warning which was mentioning that the allocation size is wrong), There isn't really the correct way of dealing with such situation, so simply fall back to Blender's knots calculation. Differential Revision: https://developer.blender.org/D7765
Reviewers: Severin Differential Revision: https://developer.blender.org/D7720
This is no longer needed for number button dragging to work properly.
Dummy typo in own recent libquery refactor, of course that one missed change was on a line not covered by our tests or the production file used for validation...
When using CTRL wheel mouse the items were selected in a different order than when opening the menu and use the wheel mouse. Reviewed By: Brecht van Lommel Differential Revision: https://developer.blender.org/D7791
This wasn't returning milliseconds, causing problems with key repeat.
This removes all use of `NULL` from the USD Exporter, also when calling into C code. No functional changes.
When rendering another scene, caching in disabled by setting local_context.skip_cache = true. Precondition checking for this flag was missing in BKE_sequencer_cache_get and it wasn't first thing to check in BKE_sequencer_cache_put. Reviewed By: brecht Differential Revision: https://developer.blender.org/D7750
Prefetching is stopped in BKE_sequencer_cache_cleanup, but is restarted quickly. Prefetching has negative effect on performance while rendering. Reviewed By: brecht Differential Revision: https://developer.blender.org/D7751
This bug is not really visible for user. When end frame is reached by prefetching thread, it doesn't stop and keeps on getting images from cache. Add chech for this situation and simplify logic involved in suspending, so it's easier to read. Reviewed By: brecht Differential Revision: https://developer.blender.org/D7757
Seams are widely used outside UV context so it's okay to duplicate entries. Based on community feedback, thanks! This reverts commit fc62a33.
All textures in workbench are using linear interpolation. The fragment shader modifies the uv coordinates to sample always in the center of a texel. In rare conditions the GPU could sample an incorrect value due to rounding errors making some rendering artifacts. This patch skips the interpolation in the fragment shader to remove these render artifacts. Reviewed By: Clément Foucault Differential Revision: https://developer.blender.org/D7816
This feature was added when Blender used tex-face (per-face images), but doesn't make as much sense since this was removed. Removing this from UV edit-mode as this wasn't working in any of the 2.8x releases, causing UV's to be visible but unselectable. Resolves issue raised in T76958.
This will allow to use foreach_get/set on enums of RNA collection items, which can save a lot of time in some cases (see incoming FBX updates).
|
Very impressive work. I appreciate the time you're spending on this, very exciting to see things coming to life. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
SpectralColoris nowfloat8)masterbranchRender speed comparison:
Color noise comparison (1 sample):