Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Django 4.2 #424

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Test on Django 4.2 #424

merged 1 commit into from
Mar 27, 2024

Conversation

adamchainz
Copy link
Contributor

Update the test matrix to test with Django 4.2, the new LTS release. No changes were needed in the package for compatibility.

I wasn't quite sure whether we'd also move the "previous" and "legacy" pins. I would recommend supporting Django 3.2 through 4.2 for the time being, since 3.2 is still supported upstream until April 2024: https://www.djangoproject.com/download/#supported-versions

@browniebroke
Copy link

I would recommend supporting Django 3.2 through 4.2 for the time being, since 3.2 is still supported upstream until April 2024

Makes sense to me.

I'm not a maintainer, but a reasonable strategy might be to change the"previous" to 4.1, and leave "legacy" as 3.2. That would mean 4.0 is technically not tested, but if it works on 3.2, 4.1 and 4.2, it's probably fine on 4.0.

Also, 4.0 is out of extended support upstream, not sure if django-countries wants to stop advertising support for it and remove the trove classifier.

Just my 2 cents as a user of the lib.

@adamchainz adamchainz mentioned this pull request Oct 13, 2023
@chaudhary-kaushal
Copy link

chaudhary-kaushal commented Jan 24, 2024

Any chance this could be released? It's blocking our upgrade to Django 4.2
Thanks.

@browniebroke
Copy link

It's blocking our upgrade to Django 4.2

It shouldn't be a blocker: there is no actual code being fixed here, it's just to cover testing, and everything passes. Are you getting a specific error? If so, it might be more productive to report it in a separate issue.

@adamchainz
Copy link
Contributor Author

Yes, this PR revealed no issues on 4.2. My follow-up, #438 , did fix some issues for Django 5.0.

@claudep
Copy link

claudep commented Mar 26, 2024

@MarcoGlauser What about starting with this simple one 😉

@SmileyChris SmileyChris merged commit 50ac1b1 into SmileyChris:main Mar 27, 2024
4 checks passed
@adamchainz adamchainz deleted the django_4.2 branch April 3, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants