Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias namer not working #543

Closed
Takiro opened this issue May 9, 2020 · 2 comments · Fixed by #544
Closed

alias namer not working #543

Takiro opened this issue May 9, 2020 · 2 comments · Fixed by #544

Comments

@Takiro
Copy link
Contributor

Takiro commented May 9, 2020

The alias namer is not working as expected. The alias is always missing. I found the issue in the namer module. the alias function checks the thumbnail_options dict for a key named ALIAS, however thumbnail_options does never contain the alias name.

def alias(thumbnailer, thumbnail_options, source_filename,
        thumbnail_extension, **kwargs):
    return '.'.join([source_filename, thumbnail_options.get('ALIAS', ''), thumbnail_extension])
@rbbonfim
Copy link

@Takiro did you find the problem?

@Takiro
Copy link
Contributor Author

Takiro commented May 16, 2020

Yes, I just opened a pull request with a fix #544

jrief added a commit that referenced this issue May 17, 2020
add alias name to the thumbnail options (fixes #543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants