Check for cleared file value #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A file field maybe False when cleared via ClearableFormInput
jrief
approved these changes
Apr 18, 2017
SmileyChris
reviewed
Aug 8, 2017
|
I added a test, but I'm not entirely clear if this is the best way to test it. However, I noticed that Django itself has the same check in its own |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clearing a file in the Django Admin by checking the "Clear" checkbox, you get the following error on this line:
AttributeError: 'bool' object has no attribute '_committed'A file field value maybe
Falsewhen cleared via ClearableFileInput. This PR checks the value before accessing_committed.