Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forgotten migration file #575

Closed
wants to merge 1 commit into from
Closed

add forgotten migration file #575

wants to merge 1 commit into from

Conversation

ozmax
Copy link

@ozmax ozmax commented Aug 22, 2021

The 3rd migration file is not commited to the project. This commit adds the migration file.

@jaap3
Copy link
Contributor

jaap3 commented Aug 26, 2021

This only happens when you install easy-thumbnails in a Django 3.2 project. Django has switched the default auto field to BigAutoField. easy-thumbnails is not yet compatible with Django 3.2 so that's why you get this migration file. See also PR #573 and issue #574

@ozmax
Copy link
Author

ozmax commented Aug 26, 2021

@jaap3 Indeed, thanks for the follow up. Could we just keep the AutoField setting on the easy-thumbnails app config so it will both not create new migrations and it will not conflict with the main django setting the user has chosen?
Also, i am currently using the easy-thumbnails app on a django 3.2 project, so if there is something to do or test in order to help, please let me know :)

@jaap3
Copy link
Contributor

jaap3 commented Aug 26, 2021

Yes, setting default_auto_field is one of the things I did in PR #573.

I'm not one of the maintainers of this project, I've only contributed every now and then. I cannot tell you what needs to happen before that PR can get merged or an official Django 3.2 supporting version can be released. I think it's mostly in the hands of @jrief, as I believe @SmileyChris has largely abandoned this project.

From issue #574 I understood that help is required to move from Travis to GitHub actions. It's not directly related to getting Django 3.2 support released, but if might help.

@jrief
Copy link
Collaborator

jrief commented Oct 14, 2021

Thanks to PR #573 there is no need for this migration anymore.

@jrief jrief closed this Oct 14, 2021
@ozmax ozmax deleted the ozmax/forgotten-migration branch October 24, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants