Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace print() against self.stdout/stderr #579

Merged
merged 3 commits into from Oct 17, 2021
Merged

Conversation

jrief
Copy link
Collaborator

@jrief jrief commented Oct 14, 2021

Superseeds #539

replace print statements in management command against self.stdout, self.stderr as required by best Django practices.

@jrief
Copy link
Collaborator Author

jrief commented Oct 14, 2021

@jaap3 could you please quickly review this pr for version 2.7.2.

@jrief jrief mentioned this pull request Oct 14, 2021
@jaap3
Copy link
Contributor

jaap3 commented Oct 15, 2021

Thanks @jrief, the from django.utils.timezone import datetime, timedelta imports are still there, but I guess I cannot convince you on that. Everything else looks good to me, so to not obstruct a next release I'll just approve this as is.

@jrief jrief merged commit 269bbdd into master Oct 17, 2021
@jrief
Copy link
Collaborator Author

jrief commented Oct 17, 2021

@jaap3 just released 2.7.2.

Thanks for reminding me about releasing a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants