Don't consider timezone-aware fields specially #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some devices do add timezones to some fields, for example the Galaxy S8 has a |
Currently, timestamp metadata fields later in the preferred field list can override earlier ones if the later one contains a timezone. This causes `GPSDateTime` to override `DateTimeOriginal`, though in practice the GPS timestamps only ever seem to use UTC (= `Z`) rather than any locale-aware timezones. This excludes `GPSDateTime` from being preferred just because it has a timestamp (it'll still be used in the absence of other fields). Fixes SmilyOrg#99.
Terrance
force-pushed
the
date-field-order
branch
from
79980a3
to
098aeb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, timestamp metadata fields later in the preferred field list can override earlier ones if the later one contains a timezone. This causes
GPSDateTimeto overrideDateTimeOriginal, though in practice the GPS timestamps only ever seem to use UTC (=Z) rather than any locale-aware timezones.This excludes
GPSDateTimefrom being preferred just because it has a timestamp (it'll still be used in the absence of other fields).Fixes #99.