Add location information to timeline #59
Conversation
|
Hey, thanks a lot for contributing! I've been meaning to add something like this, just haven't gotten around to it yet! I'll take a look at the code when I get the chance, but it looks good from a first glance. One interesting synergy might also be with the tagging system I've been trialing in a branch. The reverse geo could be used to create tags like "city:Dublin", "country:Ireland", etc. Would make it neat for search. |
| @@ -0,0 +1,3 @@ | |||
| ALTER TABLE infos DROP COLUMN "longitude" text; | |||
| ALTER TABLE infos DROP COLUMN "latitude" text; | |||
| ALTER TABLE infos DROP COLUMN "location" text; | |||
There was a problem hiding this comment.
rgeo seems to be fast enough that the location text itself might not even need to be cached? In my quick profiling the reverse geocoding almost doesn't show up. Instead it could happen at "layout-time".
internal/image/source.go
Outdated
| @@ -161,6 +164,15 @@ func NewSource(config Config, migrations embed.FS, migrationsThumbs embed.FS) *S | |||
| source.database = NewDatabase(filepath.Join(config.DataDir, "photofield.cache.db"), migrations) | |||
| source.imageInfoCache = newInfoCache() | |||
| source.pathCache = newPathCache() | |||
|
|
|||
| r, err := rgeo.New(rgeo.Provinces10, rgeo.Cities10) | |||
There was a problem hiding this comment.
This takes about half a minute to init on my (admittedly quite old) PC.
Maybe a good idea would be to load it async (e.g. in a goroutine) just so that restarts don't take that long?
Alternatively rgeo could be extended to use a sqlite file instead of JSON for the loading, or maybe even for the queries itself. Should be way faster :)
internal/image/source.go
Outdated
|
|
||
| if err != nil { | ||
| // Handle error | ||
| fmt.Println("RGEO ERR", err) |
There was a problem hiding this comment.
| fmt.Println("RGEO ERR", err) | |
| log.Fatalf("failed to init rgeo: %s", err) |
internal/layout/timeline.go
Outdated
| @@ -103,6 +105,8 @@ func LayoutTimeline(layout Layout, collection collection.Collection, scene *rend | |||
| Interval: 1 * time.Second, | |||
| } | |||
|
|
|||
| locations := make(map[string]bool) | |||
There was a problem hiding this comment.
The dedup here is pretty good already, but it can still be a bit verbose at times. One idea might also be to only list the different cities if they are all in the same country, or different countries or regions if not. That might take a bit to figure out though, maybe better left for v2 :)
| ALTER TABLE infos DROP COLUMN "longitude" text; | ||
| ALTER TABLE infos DROP COLUMN "latitude" text; | ||
| ALTER TABLE infos DROP COLUMN "location" text; |
There was a problem hiding this comment.
Types are not needed while dropping columns.
| ALTER TABLE infos DROP COLUMN "longitude" text; | |
| ALTER TABLE infos DROP COLUMN "latitude" text; | |
| ALTER TABLE infos DROP COLUMN "location" text; | |
| ALTER TABLE infos DROP COLUMN "longitude"; | |
| ALTER TABLE infos DROP COLUMN "latitude"; | |
| ALTER TABLE infos DROP COLUMN "location"; |
|
Thanks for taking a look!! I'm not sure that I'll have much time in the next few weeks to get back to this, so please feel free to take it over and combine it with other features that you're working on. If I get some time before then, I'll make the changes to address your comments |
* Use standard LatLng for storing geolocation * Fix migrations to take into account latest main * Better location text construction
|
@zach-capalbo I finally took some time to make the changes above! I still think the rgeo initialization time is a bit of a non-starter to be able to merge this as is, but it should be fine if it's behind a feature flag. In fact, lemme do that... |
Photofield is great! But I sometimes forget where I've taken my photos, so I've added some code to extract the GPS coordinates from the EXIF data, and use rgeo to lookup the location. Coordinates and location are stored in the database. Unique locations are displayed on the timeline events next to the date.
I'm submitting this PR in case this is useful or helpful. Feel free to accept it or not if it aligns with the goals of the photofield project. Just some notes about this implementation:
Anyway, hope this is helpful in some way!