HardwarePWM: Fix period unit in comments to uS instead of nS #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pief Would it be possible to add also link in the changed comment pointing to the technical reference that you are mentioning? |
1000 ms are 1000 * 0,001s = 1s which gives a frequency of 1/1 = 1 Hz
instead of 1 KHz. Now either the period or the frequency is wrong. Turns
out it's the period as the ESP8266 Technical Reference [1] associates
1000 uS with 1 KHz.
[1]: Espressif: ESP8266 Technical Reference, Chapter 12 (PWM Interface):
http://espressif.com/sites/default/files/documentation/esp8266-technical_reference_en.pdf
pief
force-pushed
the
fix/hwpwm-comments
branch
from
67d2bfa
to
827c9ff
Compare
|
Like this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1000 ms are 1000 * 0,001s = 1s which gives a frequency of 1/1 = 1 Hz
instead of 1 KHz. Now either the period or the frequency is wrong. Turns
out it's the period as the ESP8266 Technical Reference associates
1000 uS with 1 KHz.