Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: distance measurement using vl53l0x sensor #2050

Merged
merged 4 commits into from Feb 25, 2020
Merged

Feature: distance measurement using vl53l0x sensor #2050

merged 4 commits into from Feb 25, 2020

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Feb 20, 2020

No description provided.

@slaff slaff added this to the 4.1.1 milestone Feb 20, 2020
@slaff slaff requested a review from mikee47 February 20, 2020 12:21
mikee47
mikee47 approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@mikee47 mikee47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice find on the sensor! The library README.md file needs fixing though as it messes up documentation. Just need to move build status onto a separate line.

samples/Distance_Vl53l0x/app/application.cpp Outdated Show resolved Hide resolved
samples/Distance_Vl53l0x/app/application.cpp Outdated Show resolved Hide resolved
@slaff slaff merged commit 3d5dc32 into SmingHub:develop Feb 25, 2020
@slaff slaff mentioned this pull request May 8, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikee47 mikee47 mikee47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slaff @mikee47 @slav-at-attachix