Build.mk changes to allow the use of CPPFLAGS, CFLAGS and CXXFLAGS. #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d if the following is observed - CPPFLAGS - common flags for C and C++ - CFLAGS - C only flags - CXXFLAGS - C++ only flags In addition some toolchains require special standard for their C or C++ headers. Therefore every architecture should be responsible in the Arch/*/build.mk to set the C standard as a CFLAG.
…FLAGS, CFLAGS and CXXFLAGS.
slaff
force-pushed
the
feature/cpp-c-cxx-flags
branch
from
ff48223
to
14857ab
Compare
mikee47
approved these changes
May 7, 2020
Sming/Arch/Esp8266/build.mk
Outdated
| @@ -4,7 +4,8 @@ | |||
| # | |||
| ############## | |||
|
|
|||
| CFLAGS += -DARCH_ESP8266 | |||
| CPPFLAGS += -DARCH_ESP8266 | |||
| CFLAGS += -std=c11 | |||
There was a problem hiding this comment.
Should C coding standard be set in main build.mk file, rather than repeating for arch. ?
There was a problem hiding this comment.
Should C coding standard be set in main build.mk file, rather than repeating for arch. ?
We could set a default one in the main build.mk file but allow every architecture to change it if needed. For Arch Esp32 we need c99 standard for the c files otherwise too may problems pop-up.
Sming/building.rst
Outdated
Comment on lines
642
to
644
| .. envvar:: COMPONENT_CFLAGS | ||
|
|
||
| Used to provide **ONLY** C++ flags that are applied globally. |
There was a problem hiding this comment.
Remove - already listed above (lines 599 - 605).
| @@ -116,7 +116,7 @@ CFLAGS_COMMON = \ | |||
| -ffunction-sections | |||
There was a problem hiding this comment.
CFLAGS_COMMON can probably just be rolled into CPPFLAGS, it's not used anywhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR it was impossible to set easily C only flag because CFLAGS was used to set both C and C++ flags.
With this PR the common C/C++ flags should be set using the CPPFLAGS, as in a standard makefile.
With this change CFLAGS will be further on used ONLY for C compilation flags.
This PR is part of the changes needed to allow the compilation of the upcoming ESP32 architecture.
With this PR CPPFLAGS, CFLAGS and CXXFLAGS are allowed only in the Sming/Arch/*/build.mk files and should not be used in a component or application makefile.