Update/ir lib #2083
Merged
Update/ir lib #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… June 6th 2020 (Add support for Midea24 protocol)
…ng an upgrade of the IR lib from one commit to another, and not applying Sming specific changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to make the commit comments detailed. In short - the old IR.patch is deleted and new one is introduced. Tried to keep the patch minimal. Only some defines were changed and call to ESP.restart() is changed to System.restart().
The sample is updated in according to the lib.
I hardly can decide if the previous IR.patch is just patching IR lib for Sming, contains update of the IR lib itself (thaw would be wrong) or IR lib patch + Sming features. I saw IRDelegate there and I'm not sure if entirely replacing it would hurt someone's code.
Also I'm not 100% sure that this define macro is OK:
defined(F_CPU) == 160000000L
However this compiles OK and works for me (compared to the non-updated version).
Edit: I also didn't test the IR send. Should work though.