Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPnP code generation #2154

Merged
merged 5 commits into from Dec 9, 2020
Merged

UPnP code generation #2154

merged 5 commits into from Dec 9, 2020

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Nov 21, 2020

Further development to UPnP framework.
Some additions required to the build system to support intermediate code generation.

  • Add COMPONENT_PREREQUISITES and COMPONENT_BUILD_BASE to build framework
  • Fix ListAllSubDirs - should be able to handle multiple arguments
  • Add ListAllFiles and dirx
  • Add UPnP-Schema library
  • Update SSDP, UPnP, HueEmulator libraries

@mikee47 mikee47 changed the title UPnP code generation [WIP] UPnP code generation Nov 21, 2020
@mikee47 mikee47 mentioned this pull request Nov 21, 2020
Merged
16 tasks
@slaff slaff added this to the 4.2.0 milestone Nov 21, 2020
@slaff
Copy link
Contributor

slaff commented Nov 22, 2020

@mikee47 Ping me when this PR is ready.

This was referenced Nov 24, 2020
Closed
Closed
@mikee47 mikee47 force-pushed the feature/upnp-code-gen branch 8 times, most recently from 3e03414 to 8b54798 Compare November 28, 2020 21:45
@mikee47
Copy link
Contributor Author

mikee47 commented Nov 29, 2020

@slaff If we wait until #2151 is merged I can test/rebase first.

@mikee47 mikee47 force-pushed the feature/upnp-code-gen branch 6 times, most recently from 5921027 to 08f7083 Compare December 4, 2020 17:32
@slaff
Copy link
Contributor

slaff commented Dec 8, 2020

@mikee47 Are you planning further changes to this PR or I should merge it?

@mikee47
Copy link
Contributor Author

mikee47 commented Dec 8, 2020

@slaff I need to rebase, re-test and confirm behaviour. Will probably have to just accept any quirks for now - did a quick test of #2175 and it made no difference so I need to spend more time trying to reproduce the problem more concisely. It's not a show-stopper though.

@mikee47
Copy link
Contributor Author

mikee47 commented Dec 8, 2020

@slaff You've fixed the issue with task queues - Thank you! Happy to merge now.

@slaff slaff changed the title [WIP] UPnP code generation UPnP code generation Dec 9, 2020
@slaff slaff merged commit 7e648be into SmingHub:develop Dec 9, 2020
@slaff slaff removed the 3 - Review label Dec 9, 2020
@mikee47 mikee47 deleted the feature/upnp-code-gen branch December 9, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikee47 @slaff