Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for repeated HTTP header fields #2290

Merged
merged 9 commits into from Mar 29, 2021

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Mar 26, 2021

Some fields can appear multiple times in one HTTP response or request.

The following headers are supported:

  • Set-Cookie
  • WWW-Authenticate
  • Proxy-Authenticate

Updated HttpResponse::setCookie to support adding multiple cookies in one response.

…response or request.

The following headers are supported:
- Set-Cookie
- WWW-Authenticate
- Proxy-Authentica

Updated HttpResponse::setCookie to support adding multiple cookies in one response.
@slaff slaff added this to the 4.3.0 milestone Mar 26, 2021
@slaff slaff requested a review from mikee47 March 26, 2021 13:56
Copy link
Contributor

@mikee47 mikee47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slaff I've pushed some suggestions to your repo.

@mikee47 mikee47 changed the title Added support for headers that can appear multiple times in one HTTP … Add support for repeated HTTP header fields Mar 28, 2021
@slaff slaff merged commit 9bb398a into SmingHub:develop Mar 29, 2021
@slaff slaff mentioned this pull request Mar 30, 2021
5 tasks
@slaff slaff deleted the feature/multiple-headers branch July 9, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants