Fix Basic_IFS sample and TemplateStream #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikee47
force-pushed
the
fix/basicifs-templatestream
branch
from
66e6474
to
c73dbb6
Compare
Tested against large (1MB) JSON listing generated from templates, issues arising. Need to check for remaining plain data before continuing with next tag search Move check for missing end tag after `evaluate`
mikee47
force-pushed
the
fix/basicifs-templatestream
branch
from
c73dbb6
to
32cbfda
Compare
slaff
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Use per-arch hardware configs, and reduce ESP32 app. partition size * Fix bug in ReadWriteStream::copyFrom() * Fix TemplateStream Tested against large (1MB) JSON listing generated from templates, issues arising. Need to check for remaining plain data before continuing with next tag search Move check for missing end tag after `evaluate` * Add test for fragmented read of variable values Verified that debug statements #1, #3 and #4 are triggered by the test. Use smaller read buffers for testing to stress code more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests with stupidly large directory listings revealed a couple of bugs in the TemplateStream code. Attempting to generate a large (1MB) JSON listing showed as corrupted in the browser, and there were a few incorrect tags which this PR fixes.
The Basic_IFS sample also no longer builds correctly for ESP32 since adding a LittleFS partition, so hardware configurations are now specialised for each arch.