Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTA Deployer should exit when there is an error. #2420

Merged
merged 1 commit into from Nov 11, 2021
Merged

OTA Deployer should exit when there is an error. #2420

merged 1 commit into from Nov 11, 2021

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Nov 10, 2021

Noticed when trying to do automatic releases for SmingSwitch

@slaff slaff added this to the 4.5.0 milestone Nov 10, 2021
@slaff
Copy link
Contributor Author

slaff commented Nov 10, 2021

The issue was that the deployer was not exiting. And the workflow was handing for ever.
With this PR it is working as expected. These finished runs 1 and 2 confirm it.

@slaff slaff removed the 3 - Review label Nov 11, 2021
@slaff slaff merged commit 7be49a4 into SmingHub:develop Nov 11, 2021
@slaff slaff mentioned this pull request Nov 16, 2021
Closed
5 tasks
@slaff slaff deleted the fix/ota-deployer-exit-on-error branch November 19, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slaff @slav-at-attachix