Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RbootUpgrader to take notice of RBOOT_RTC_ENABLED #2525

Merged
merged 1 commit into from Jul 15, 2022

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jul 14, 2022

Calling RbootUpgrader::setBootPartition with save=false doesn't work. This PR fixes the discovered issues.

  1. Compiler variable should be BOOT_RTC_ENABLED, not RBOOT_ENABLE_RTC
  2. rBoot must add this to GLOBAL_CFLAGS as it's required by the application and the Ota library
  3. RtcClass uses RTC memory at the same user address (word 64), so has been shifted up by 3 words.

This may affect user applications which use RTC data space.

@slaff slaff added this to the 4.7.0 milestone Jul 15, 2022
@slaff slaff merged commit fa026fb into SmingHub:develop Jul 15, 2022
@mikee47 mikee47 deleted the fix/rboot-rtc branch July 16, 2022 11:11
@slaff slaff mentioned this pull request Jul 25, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants