Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add general UUID / GUID support #2552

Merged
merged 10 commits into from Sep 15, 2022
Merged

Add general UUID / GUID support #2552

merged 10 commits into from Sep 15, 2022

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Sep 13, 2022 •
edited

This PR moves the Uuid object out of the SSDP library and makes some improvements.

UUIDs/GUIDs are not exclusively network entities. They're required for filesystems, for example.

  • Add template constructor for arbitrary 16-byte entities
  • Add comparison operators
  • Add Uuid test module
  • Fix test message truncation by updating SmingTest to write messages directly to Serial

Todo:

  • Replace template constructor as UUID version (endianness) must be considered

@mikee47 mikee47 changed the title Add UUID to Core/Data Add general UUID / GUID support Sep 13, 2022
@slaff slaff added this to the 4.7.0 milestone Sep 13, 2022
@slaff
Copy link
Contributor

slaff commented Sep 15, 2022

@mikee47 are you ready with this PR?

@mikee47
Copy link
Contributor Author

mikee47 commented Sep 15, 2022

@slaff Yes thanks, all done for now :-)

@slaff slaff merged commit 9ef6248 into SmingHub:develop Sep 15, 2022
@mikee47 mikee47 deleted the feature/uuid branch September 15, 2022 13:35
@slaff slaff mentioned this pull request Nov 8, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikee47 @slaff