Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esp32 Wifi Station Implementation bugfix #2600

Merged
merged 1 commit into from Jan 4, 2023
Merged

Esp32 Wifi Station Implementation bugfix #2600

merged 1 commit into from Jan 4, 2023

Conversation

mr-sven
Copy link
Contributor

@mr-sven mr-sven commented Jan 2, 2023

Fixes #2598
Do not return on enable true because if mode is already WIFI_MODE_STA or WIFI_MODE_APSTA the esp_wifi_start isn't called.

@what-the-diff
Copy link

what-the-diff bot commented Jan 2, 2023

  • The function enable() was changed to allow the user to disable wifi.
  • A new if statement was added in line 155, which checks whether enabled is true or false and then calls esp_wifi_start().

@slaff slaff added this to the 4.8.0 milestone Jan 2, 2023
@slaff slaff requested a review from mikee47 January 3, 2023 08:26
@slaff slaff merged commit 02206c8 into SmingHub:develop Jan 4, 2023
@slaff
Copy link
Contributor

slaff commented Jan 4, 2023

@mr-sven welcome to Sming and thank you for your first contribution :)

@slaff slaff mentioned this pull request Jan 4, 2023
Closed
5 tasks
@mr-sven mr-sven deleted the fix/esp32-enable-no-return branch January 4, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikee47 mikee47 Awaiting requested review from mikee47

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Esp32 Wifi Station Implementation bug
2 participants
@mr-sven @slaff