Feature/interupts fix #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
anakod
commented
Sep 29, 2016
anakod
commented
- Correct interrupts disabling implementation (based on http://www.esp8266.com/viewtopic.php?p=16758 forum topic)
- Important fix: IRAM_ATTR added to prevent crash on few interrupt callback routines.
|
@anakod This PR looks like a very nice interrupts improvement. Why don't you merge it with the rest of the code? |
slaff
pushed a commit
to slaff/Sming
that referenced
this pull request
Oct 10, 2016
|
@hreintke, we already have Arduino compatible interrupts. But it wasn't implemented right. Also all functions what can be called from interrupts should have IRAM_ATTR. If not - program will crash sometimes. |
|
@slaff Agree with you, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.