Fix panic when wayland display connection breaks #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
reviewed
Feb 19, 2024
src/worker.rs
Outdated
Comment on lines
98
to
99
| if event_loop.dispatch(None, &mut state).is_err() { | ||
| // Possibly broken connection to the display server, not much we can | ||
| // do at this point. | ||
| break; | ||
| } | ||
|
|
||
| if state.exit { | ||
| break; |
Instead, terminate the thread and consider the clipboard dead. The application can now gracefully deal with the situation. Closes #52
kchibisov
approved these changes
Feb 19, 2024
|
Could you fixup CI while at it, I don't want to push to your master branch myself. |
|
Sure :) |
Remove redundant imports
Implement std::fmt::Display instead of ToString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, terminate the thread and consider the clipboard dead. The application can now gracefully deal with the situation.
Closes #52