Upgrade winit backend to 0.17 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If is about data device manager? Smithay does not support it yet, while it's in the core protocol.
|
elinorbgr
reviewed
Sep 26, 2018
src/backend/winit.rs
Outdated
| if let Window::Wayland { ref surface, .. } = **window { | ||
| surface.resize(w as i32, h as i32, 0, 0); | ||
| surface.resize(size.width as i32, size.height as i32, 0, 0); |
There was a problem hiding this comment.
This should be a PhysicalSize given as argument to resize the egl surface
|
For the record, this looks good. I just want to sort #101 before merging it. 👍 |
…r fn resized()` to take a LogicalSize
…d()` a LogicalPosition
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the winit backend to 0.17. I couldn't test this in detail since I can't open applications in anvil because of an error about seat manager support but I would assume none of these changes would have much affect.