WIP Use PopupKind/PopupManager for input method surface
#1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Smithay#1045. This eliminates the need for `set_point`, and for the compositor to have separate code for rendering IME popups. This seems to work at least as well as the previous version with fcitx5 in anvil? The use of `set_point` previously wasn't correct. But some work is still needed. The current version of the protocol also has some fundamental issues that may be problematic here. We can bring anything like that up in discussion of the v3 protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1045. This eliminates the need for
set_point, and for the compositor to have separate code for rendering IME popups.This seems to work at least as well as the previous version with fcitx5 in anvil? The use of
set_pointpreviously wasn't correct. But some work is still needed.The current version of the protocol also has some fundamental issues that may be problematic here. We can bring anything like that up in discussion of the v3 protocol.