Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commons: fix server ids handling in map #225

Merged
merged 1 commit into from
Jan 18, 2019
Merged

commons: fix server ids handling in map #225

merged 1 commit into from
Jan 18, 2019

Conversation

elinorbgr
Copy link
Member

Client ids start at 1 and server ids start at SERVER_ID_LIMIT, not
SERVER_ID_LIMIT+1.

cc #224

Client ids start at 1 and server ids start at SERVER_ID_LIMIT, not
SERVER_ID_LIMIT+1.

cc #224
@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #225 into master will decrease coverage by 21.84%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #225       +/-   ##
===========================================
- Coverage   73.38%   51.53%   -21.85%     
===========================================
  Files          49       49               
  Lines        3505     3419       -86     
===========================================
- Hits         2572     1762      -810     
- Misses        933     1657      +724
Flag Coverage Δ
#native_lib 51.53% <0%> (+0.3%) ⬆️
#rust_impl ?
Impacted Files Coverage Δ
wayland-commons/src/map.rs 7.14% <0%> (-75.76%) ⬇️
wayland-server/src/rust_imp/globals.rs 0% <0%> (-79.55%) ⬇️
wayland-server/src/rust_imp/resources.rs 0% <0%> (-76.32%) ⬇️
wayland-server/src/rust_imp/clients.rs 0% <0%> (-74.56%) ⬇️
wayland-server/src/rust_imp/display.rs 0% <0%> (-74.55%) ⬇️
wayland-client/src/rust_imp/display.rs 0% <0%> (-72.35%) ⬇️
wayland-server/src/rust_imp/mod.rs 0% <0%> (-70%) ⬇️
wayland-client/src/rust_imp/proxy.rs 0% <0%> (-69.35%) ⬇️
wayland-server/src/rust_imp/event_loop_glue.rs 0% <0%> (-66.67%) ⬇️
wayland-client/src/rust_imp/queues.rs 0% <0%> (-63.27%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d192197...bc7d804. Read the comment docs.

@elinorbgr
Copy link
Member Author

The coverage issue is linked to xd009642/tarpaulin#190, I'll ignore it.

@elinorbgr elinorbgr merged commit 738fc3b into master Jan 18, 2019
@elinorbgr elinorbgr deleted the fix_server_ids branch February 3, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant