Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Scan #43

Closed
4 tasks done
villanueval opened this issue Aug 9, 2023 · 8 comments
Closed
4 tasks done

Accessibility Scan #43

villanueval opened this issue Aug 9, 2023 · 8 comments
Assignees
Labels
accessibility Issues to meet accessibility requirements

Comments

@villanueval
Copy link
Member

villanueval commented Aug 9, 2023

The new accessibility scan (ticket RITM0090813) found four issues:

  • The tool buttons on the graph of the Summary tab of the homepage does not receive any keyboard focus. This still does not work for keyboard only users. The screenreaders read each of the graph tools as “graphic” or “link” without giving any context as to what those tools are
  • The keyboard focus disappears after the “Summary” tab of the homepage until the footer. The keyboard focus should never disappear from sight
  • For the graph on the Summary tab of the homepage, add a long description or a caption that gives a very brief overview such as the starting data point and the overall trend one sees when looking at a graph. Please add this before the table begins. See this page for more information [https://www.w3.org/WAI/tutorials/images/complex/]
  • Hidden table “Cummulative number of images captured and objects digitized by the Digitization Program Office ...“ on https://dt-vmdpoqc01.si.edu/
@villanueval villanueval added the accessibility Issues to meet accessibility requirements label Aug 9, 2023
@villanueval villanueval self-assigned this Aug 9, 2023
@villanueval
Copy link
Member Author

Graph is removed in 7b42ea4 and replaced with cards highlighting some projects.

@villanueval
Copy link
Member Author

Tabs have been replaced by separate pages by team.

@villanueval
Copy link
Member Author

villanueval commented Sep 19, 2023

Issues identified by new scan (2023-09-19):

  • There’s skipped headings on the homepage that goes from the h1 of the blue numbers such as “10” Active Projects to h5 of Project Dashboard titles such as “Digitization of the JPC Archive has Started”

Level A

  • Some pages have the same title , so the title cannot be used to distinguish pages. Change the title elements so they are unique for each page. WCAG 2.1 A F25 Section 508 (2017) A F25
    • Title in homepage is the same between teams
    • Pagination in project dashboard returns the same title:
      • 'JPC Archive Pilot RO_OVI_003A_20230817 - Project Dashboard' is also used on dashboard/jpc_pilot/3417/ . dashboard/jpc_pilot/3417/?tab=1&page=2 line 102
  • The aria-controls attribute must point to IDs of elements in the same document. WCAG 2.1 A 1.3.1 Section 508 (2017) A 1.3.1 ARIA 1.1

Level AA

  • Ensure that text and background colors have enough contrast WCAG 2.1 AA 1.4.3 Section 508 (2017) AA 1.4.3
    • Seems the "DEV VERSION" tag triggers this issue (class="text-black bg-warning"; link to base template
    • Team buttons on homepage using the white on light blue text ("btn border-info btn-outline-info text-black")
  • Headings should not be empty. Add text to the heading, or alt text if the heading contains an image. Screen readers read out page headings, allowing users to quickly skip to a section, but some older screen readers do not ignore empty headings. WCAG 2.1 AA G130 Section 508 (2017) AA G130
    • Empty statistics in the Informatics Team page (<div class="card-body"><h1></h1></div>...)
  • If you set any of the colors on the body or a elements you must set all of them. In HTML the color attributes are text , bgcolor , link , alink and vlink . In CSS the attributes are color and background-color . Some users have browser defaults set to white text on a black background, so setting one color without setting the others can result in black text on a black background. WCAG 2.1 AA F24 Section 508 (2017) AA F24
  • The CSS outline or border style on this element makes it difficult or impossible to see the dotted link focus outline. Do not remove the default outline style, and change any border styles to avoid obscuring the focus outline around focusable elements. WCAG 2.1 AA F78 Section 508 (2017) AA F78

@villanueval
Copy link
Member Author

Level A - Title in homepage is the same between teams - Fixed in 2afe168

@villanueval
Copy link
Member Author

Level A - Pagination in project dashboard returns the same title - Fixed in b1a18c9

@villanueval
Copy link
Member Author

villanueval commented Sep 21, 2023

Level A - The aria-controls attribute must point to IDs of elements in the same document.

  • Elements left behind from test navigation components. Removed.

Level AA - Ensure that text and background colors have enough contrast

  • One issue was a notice at the top of the pages. This was removed.
  • White on blue buttons were replaced with white-on-black or black-on-white buttons.

Level AA - Headings should not be empty. Add text to the heading, or alt text if the heading contains an image.

  • Caused by a templated table with no data. Added code to not display if there are no rows in the table.

Level AA - If you set any of the colors on the body or a elements you must set all of them.

  • All elements were updated to specify text and background color together.

Level AA - The CSS outline or border style on this element makes it difficult or impossible to see the dotted link focus outline.

  • Simplified styling of the form.

@villanueval
Copy link
Member Author

There’s skipped headings on the homepage

  • Reformatted home to avoid these in 70c4940

@villanueval
Copy link
Member Author

New scan on 2023-09-22 just found false positives. We are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues to meet accessibility requirements
Projects
None yet
Development

No branches or pull requests

1 participant