Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model displays flat black in Voyager, but with correct diffust color in other three.js and babylon.js viewers #123

Closed
blundellj opened this issue Mar 4, 2022 · 3 comments
Closed

Model displays flat black in Voyager, but with correct diffust color in other three.js and babylon.js viewers #123

blundellj opened this issue Mar 4, 2022 · 3 comments

Comments

@blundellj
Copy link
Collaborator

Screen Shot 2022-03-04 at 4 28 38 PM
Voyager

Screen Shot 2022-03-04 at 4 29 34 PM
https://gltf-viewer.donmccurdy.com/

Model Link
@csparker247
Copy link
Contributor

I just ran across this. In my case, the mesh didn't have surface normals, which are required for the default directional lighting.

@gjcope
Copy link
Collaborator

gjcope commented Apr 8, 2022

Thanks @csparker247 ! You are absolutely right, that model did not have surface normals.

gjcope added a commit that referenced this issue Apr 26, 2022
@gjcope
Shader cleanup. Added flatShaded support to fix bug #123
d582516
@gjcope
Copy link
Collaborator

gjcope commented May 2, 2022

This is fixed in v0.17.0 by supporting the flatShaded attribute.

@gjcope gjcope closed this as completed May 2, 2022
sdumetz pushed a commit to sdumetz/dpo-voyager that referenced this issue Jan 3, 2024
@gjcope
Shader cleanup. Added flatShaded support to fix bug Smithsonian#123
43f6abc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@csparker247 @gjcope @blundellj